8

There's codereview stackexchange to ask to get.. well your code reviewed :D. Unfortunately, there doesn't seem to be anything equivalent for database reviewing.

Would it be appropriate to put database/schema design here with Model / EER diagram and ask for a review on it?

4

2 Answers 2

7

I think there are two types of database design questions. There is the actual questions such as "I'm trying to work out a database design for ...." and very nit picky questions of "I have this database design and I was wondering what you guys think about it". The later will result mostly in opinions and not really a useful entry in a Q&A forum.

E.g. Can Anyone please review my database after I did the Normalization ?.Any suggestion is appreciated

It is hard to give a definite answer to the question asked. Hence so far there are only comments. That's really what the person is after when asking this question - he wants input from others so he can make his final decision, so you will see mostly comments as answer, since it's not really a question.

The question being "can anyone please review.." the answer is "Yes" or "No" :)

So I think that type of question does not belong.

But there has been other good database design questions too which I think would belong as they provide good data for others to use in the future.

Is it important to design the database the right way from the beginning?

Best design for a many:many relationship issue

0

No – use Code Review. Personally, as a convert to the ways of maintaining database schemas as code (scripts), I'm firmly of the belief that databases are (in many ways) code.

4
  • 1
    The actual advice on Code Review meta is a little more nuanced than that. As a philosophical question, database schemas can be code, but they certainly are not just code. Sep 5, 2013 at 22:03
  • @JonEricson – when a co-founder of the Stack Exchange family of sites writes "I would say this is in the correct spirit of code review, provided the relevant schemas are provided in the question.", then I think it's pretty straightforward and mostly lacking in nuance. Aside from any "philosophical question", what exactly is it about database schemas that is significantly different from other examples of code that is pertinent to this question? Sep 10, 2013 at 13:35
  • A create script is code. A database design is not. Sep 24, 2013 at 4:22
  • The design of code, for both 'real' code or a database 'create script' (or a SQL query) is to varying degrees implied. I'm pretty sure 'code reviews' aren't strictly limited to claiming whether code works or not, so the same should apply to database designs. Some context about the code that will use the database would be useful, just like the same would be useful when discussing the design of a 'regular' API. Sep 24, 2013 at 11:56

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .