3 replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
source | link

Imagine a junior database developer / DBA that may not have an avenue to get their SQL code reviewed for best practices and such as they are learning the ropes. There is of course the Code Review Stack ExchangeCode Review Stack Exchange (CR.SE) site, which can and will review SQL if it is posted and falls within the site guidelines.

However, there are a few concerns in that regards. The primary one IMO is:

Real DB objects vs. hypothetical ones

CR.SE questions must include real code that OP owns or maintains; this can present a challenge as a good portion of SQL code is often DB object names, which can present security or regulation repercussions to the OP for revealing those.

There is as a workaround the option to rename the DB objects to something more generic, which will preserve the logic of the code while removing potentially sensitive information. This, however, on CR.SE would likely get closed as "hypothetical code" if the reviewers saw things like

SELECT foo
FROM table1 AS "orders" 
JOIN table2 AS "customers"
  ON "orders".cust_id = "customers".id

There is also the less problematic, but still meaningful difference that many regulars on DBA.SE appear to be database professionals, rather than "programming professionals who know SQL", which might provide more valuable information to the OP's benefit (and that of potential future viewers), but the fact that there would not be a problem statement or specific question per-se related to databases might not be that well-received on DBA.SE?

--

All constructive opinions appreciated!

Imagine a junior database developer / DBA that may not have an avenue to get their SQL code reviewed for best practices and such as they are learning the ropes. There is of course the Code Review Stack Exchange (CR.SE) site, which can and will review SQL if it is posted and falls within the site guidelines.

However, there are a few concerns in that regards. The primary one IMO is:

Real DB objects vs. hypothetical ones

CR.SE questions must include real code that OP owns or maintains; this can present a challenge as a good portion of SQL code is often DB object names, which can present security or regulation repercussions to the OP for revealing those.

There is as a workaround the option to rename the DB objects to something more generic, which will preserve the logic of the code while removing potentially sensitive information. This, however, on CR.SE would likely get closed as "hypothetical code" if the reviewers saw things like

SELECT foo
FROM table1 AS "orders" 
JOIN table2 AS "customers"
  ON "orders".cust_id = "customers".id

There is also the less problematic, but still meaningful difference that many regulars on DBA.SE appear to be database professionals, rather than "programming professionals who know SQL", which might provide more valuable information to the OP's benefit (and that of potential future viewers), but the fact that there would not be a problem statement or specific question per-se related to databases might not be that well-received on DBA.SE?

--

All constructive opinions appreciated!

Imagine a junior database developer / DBA that may not have an avenue to get their SQL code reviewed for best practices and such as they are learning the ropes. There is of course the Code Review Stack Exchange (CR.SE) site, which can and will review SQL if it is posted and falls within the site guidelines.

However, there are a few concerns in that regards. The primary one IMO is:

Real DB objects vs. hypothetical ones

CR.SE questions must include real code that OP owns or maintains; this can present a challenge as a good portion of SQL code is often DB object names, which can present security or regulation repercussions to the OP for revealing those.

There is as a workaround the option to rename the DB objects to something more generic, which will preserve the logic of the code while removing potentially sensitive information. This, however, on CR.SE would likely get closed as "hypothetical code" if the reviewers saw things like

SELECT foo
FROM table1 AS "orders" 
JOIN table2 AS "customers"
  ON "orders".cust_id = "customers".id

There is also the less problematic, but still meaningful difference that many regulars on DBA.SE appear to be database professionals, rather than "programming professionals who know SQL", which might provide more valuable information to the OP's benefit (and that of potential future viewers), but the fact that there would not be a problem statement or specific question per-se related to databases might not be that well-received on DBA.SE?

--

All constructive opinions appreciated!

    Tweeted twitter.com/#!/StackDBAs/status/632490208026566656
2 added 28 characters in body
source | link

Imagine a junior database developer / DBA that may not have an avenue to get their SQL code reviewed for best practices and such as they are learning the ropes. There is of course the Code Review Stack Exchange (CR.SE) site, which can and will review SQL if it is posted and falls within the site guidelines.

However, there are a few concerns in that regards. The primary one IMO is:

Real DB objects vs. hypothetical ones

CR.SE questions must include real code that OP owns or maintains; this can present a challenge as a good portion of SQL code is often DB object names, which can present security or regulation repercussions to the OP for revealing those.

There is as a workaround the option to rename the DB objects to something more generic, which will preserve the logic of the code while removing potentially sensitive information. This, however, on CR.SE would likely get closed as "hypothetical code" if the reviewers saw things like

SELECT foo
FROM table1 AS "orders" 
JOIN table2 AS "customers"
  ON "orders".cust_id = "customers".id

There is also the less problematic, but still meaningful difference that many regulars on DBA.SE appear to be database professionals, rather than "programming professionals who know SQL", which might provide more valuable information to the OP's benefit (and that of potential future viewers), but the fact that there would not be a problem statement or specific question per-se related to databases might not be that well-received on DBA.SE?

--

All constructive opinions appreciated!

Imagine a junior database developer / DBA that may not have an avenue to get their SQL code reviewed as they are learning the ropes. There is of course the Code Review Stack Exchange (CR.SE) site, which can and will review SQL if it is posted and falls within the site guidelines.

However, there are a few concerns in that regards. The primary one IMO is:

Real DB objects vs. hypothetical ones

CR.SE questions must include real code that OP owns or maintains; this can present a challenge as a good portion of SQL code is often DB object names, which can present security or regulation repercussions to the OP for revealing those.

There is as a workaround the option to rename the DB objects to something more generic, which will preserve the logic of the code while removing potentially sensitive information. This, however, on CR.SE would likely get closed as "hypothetical code" if the reviewers saw things like

SELECT foo
FROM table1 AS "orders" 
JOIN table2 AS "customers"
  ON "orders".cust_id = "customers".id

There is also the less problematic, but still meaningful difference that many regulars on DBA.SE appear to be database professionals, rather than "programming professionals who know SQL", which might provide more valuable information to the OP's benefit (and that of potential future viewers), but the fact that there would not be a problem statement or specific question per-se related to databases might not be that well-received on DBA.SE?

--

All constructive opinions appreciated!

Imagine a junior database developer / DBA that may not have an avenue to get their SQL code reviewed for best practices and such as they are learning the ropes. There is of course the Code Review Stack Exchange (CR.SE) site, which can and will review SQL if it is posted and falls within the site guidelines.

However, there are a few concerns in that regards. The primary one IMO is:

Real DB objects vs. hypothetical ones

CR.SE questions must include real code that OP owns or maintains; this can present a challenge as a good portion of SQL code is often DB object names, which can present security or regulation repercussions to the OP for revealing those.

There is as a workaround the option to rename the DB objects to something more generic, which will preserve the logic of the code while removing potentially sensitive information. This, however, on CR.SE would likely get closed as "hypothetical code" if the reviewers saw things like

SELECT foo
FROM table1 AS "orders" 
JOIN table2 AS "customers"
  ON "orders".cust_id = "customers".id

There is also the less problematic, but still meaningful difference that many regulars on DBA.SE appear to be database professionals, rather than "programming professionals who know SQL", which might provide more valuable information to the OP's benefit (and that of potential future viewers), but the fact that there would not be a problem statement or specific question per-se related to databases might not be that well-received on DBA.SE?

--

All constructive opinions appreciated!

1
source | link

Which site is best for code reviews of queries?

Imagine a junior database developer / DBA that may not have an avenue to get their SQL code reviewed as they are learning the ropes. There is of course the Code Review Stack Exchange (CR.SE) site, which can and will review SQL if it is posted and falls within the site guidelines.

However, there are a few concerns in that regards. The primary one IMO is:

Real DB objects vs. hypothetical ones

CR.SE questions must include real code that OP owns or maintains; this can present a challenge as a good portion of SQL code is often DB object names, which can present security or regulation repercussions to the OP for revealing those.

There is as a workaround the option to rename the DB objects to something more generic, which will preserve the logic of the code while removing potentially sensitive information. This, however, on CR.SE would likely get closed as "hypothetical code" if the reviewers saw things like

SELECT foo
FROM table1 AS "orders" 
JOIN table2 AS "customers"
  ON "orders".cust_id = "customers".id

There is also the less problematic, but still meaningful difference that many regulars on DBA.SE appear to be database professionals, rather than "programming professionals who know SQL", which might provide more valuable information to the OP's benefit (and that of potential future viewers), but the fact that there would not be a problem statement or specific question per-se related to databases might not be that well-received on DBA.SE?

--

All constructive opinions appreciated!